Fix linter warnings and go fmt

cmd/meshnamed/main.go

@@ -47,14 +47,13 @@ func init() {
 	flag.StringVar(&useconffile, "useconffile", "", "run daemon with a config file")
 	flag.StringVar(&listenAddr, "listenaddr", "[::1]:53535", "address to listen on")
 	flag.StringVar(&networksconf, "networks", "ygg=200::/7,cjd=fc00::/8,meshname=::/0", "TLD=subnet list separated by comma")
-	flag.BoolVar(&debug,"debug", false, "enable debug logging")
+	flag.BoolVar(&debug, "debug", false, "enable debug logging")
 }
 
 func main() {
 	flag.Parse()
 
-	var logger *log.Logger
+	logger := log.New(os.Stdout, "", log.Flags())
-	logger = log.New(os.Stdout, "", log.Flags())
 
 	logger.EnableLevel("error")
 	logger.EnableLevel("warn")
@@ -86,7 +85,9 @@ func main() {
 		}
 	}
 
-	s.Start()
+	if err := s.Start(); err != nil {
+		logger.Fatal(err)
+	}
 	logger.Infoln("Listening on:", listenAddr)
 
 	c := make(chan os.Signal, 1)
@@ -96,9 +97,9 @@ func main() {
 	defer s.Stop()
 	for {
 		select {
-		case _ = <-c:
+		case <-c:
 			return
-		case _ = <-r:
+		case <-r:
 			if useconffile != "" {
 				if err := loadConfig(s, useconffile); err != nil {
 					logger.Errorln(err)

pkg/meshname/config.go

@@ -10,7 +10,6 @@ import (
 	"github.com/miekg/dns"
 )
 
-
 func GenConf(target, zone string) (string, error) {
 	ip := net.ParseIP(target)
 	if ip == nil {
@@ -50,4 +49,3 @@ func ParseZoneConfigMap(zoneConfigMap map[string][]string) (map[string][]dns.RR,
 	}
 	return zoneConfig, nil
 }
-

pkg/meshname/domain_test.go

@@ -2,9 +2,9 @@ package meshname
 
 import (
 	"bytes"
+	"fmt"
 	"net"
 	"testing"
-	"fmt"
 
 	"github.com/zhoreeq/meshname/pkg/meshname"
 )

pkg/meshname/server.go

@@ -38,16 +38,15 @@ func New(log *log.Logger, listenAddr string) *MeshnameServer {
 	}
 }
 
-func (s *MeshnameServer) Stop() error {
+func (s *MeshnameServer) Stop() {
 	s.startedLock.Lock()
 	defer s.startedLock.Unlock()
 
-	if s.started == true {
+	if s.started {
-		s.dnsServer.Shutdown()
+		if err := s.dnsServer.Shutdown(); err != nil {
+			s.log.Debugln(err)
+		}
 		s.started = false
-		return nil
-	} else {
-		return errors.New("MeshnameServer is not running")
 	}
 }
 
@@ -55,7 +54,7 @@ func (s *MeshnameServer) Start() error {
 	s.startedLock.Lock()
 	defer s.startedLock.Unlock()
 
-	if s.started == false {
+	if !s.started {
 		s.dnsServer = &dns.Server{Addr: s.listenAddr, Net: "udp"}
 		for tld, subnet := range s.networks {
 			dns.HandleFunc(tld, s.handleRequest)
@@ -129,7 +128,10 @@ func (s *MeshnameServer) handleRequest(w dns.ResponseWriter, r *dns.Msg) {
 		}
 		m.Answer = append(m.Answer, resp.Answer...)
 	}
-	w.WriteMsg(m)
+
+	if err := w.WriteMsg(m); err != nil {
+		s.log.Debugln("Error writing response:", err)
+	}
 }
 
 func (s *MeshnameServer) isRemoteLookupAllowed(addr net.Addr) bool {

pkg/meshname/server_test.go

@@ -31,7 +31,6 @@ func TestServerLocalDomain(t *testing.T) {
 		t.Fatalf("meshname: Failed to parse Meshname config: %s", err)
 	}
 
-
 	ts.Start()
 
 	tc := new(dns.Client)